Update dependencies, fix reconnection and implement darkmode #192
Conversation
|
Linting is freaking out since the used babel-eslint package is deprecated, the new @babel/eslint-parser package that replaces it functions correctly but calls out a bunch of the existing code that I didn't touch. I'm guessing that the currenting linting setup simply isn't using the majority of the linting packages it includes. Happy to work on fixing up the linting but it is probably better done in a different PR as it will touch a lot of files and obscure the more impactful changes. |
|
Thanks a lot for your effort @mfjordvald! I'll review it next week. |
There was a problem hiding this comment.
@mfjordvald Sorry for the delay. The code looks good! It would be worthwhile to add a switch for dark mode in the settings (on/off/system) if you feel up for it, but this is also fine.
Could you enable github actions on your fork so CI can run?
And could you create another PR to deal with lining? Either on top of this or based on master.
When I see the CI passing all steps I'm happy to merge and create a new release! Thanks again for your work.
|
@mfjordvald Please merge master, that should enable the CI to run on your PR. |
Apologies for a bit of a wide-ranging PR. I wanted to make some changes for myself and ended up doing a bit of maintenance to remove the deprecation warnings in the console.
The biggest maintenance items here are:
In addition this PR fixes #191 and implements #142 #165
The #191 fix is done by explicitly calling the connect function since simply calling disconnect will not trigger auto-reconnect if the socket already had an abnormal disconnection.
The dark mode feature selects the light/dark Mui palette based on the system preference.